-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precompiled libraries: only select a folder if it contains files #1134
Merged
silvanocerza
merged 5 commits into
arduino:master
from
facchinm:precompiled_only_choose_nonempty_dirs
Jan 18, 2021
Merged
Precompiled libraries: only select a folder if it contains files #1134
silvanocerza
merged 5 commits into
arduino:master
from
facchinm:precompiled_only_choose_nonempty_dirs
Jan 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
changed the title
Recompiled libraries: only select a folder if it contains files
Precompiled libraries: only select a folder if it contains files
Jan 13, 2021
facchinm
force-pushed
the
precompiled_only_choose_nonempty_dirs
branch
from
January 13, 2021 14:29
4a23f6b
to
2cbd753
Compare
facchinm
force-pushed
the
precompiled_only_choose_nonempty_dirs
branch
from
January 15, 2021 09:06
195c913
to
39a1b2b
Compare
Python tests are failing:
You should run |
We pushed some fixes to the failing steps of |
silvanocerza
force-pushed
the
precompiled_only_choose_nonempty_dirs
branch
from
January 15, 2021 16:06
31a0713
to
e19b9ec
Compare
silvanocerza
added a commit
that referenced
this pull request
Jan 27, 2021
* Precompiled libraries: only select a folder if it contains files * Restore precompiled tests * slightly refactored directoryContainsFile function * [skip changelog] Fix compile tests * [skip changelog] Fix compile test Co-authored-by: Cristian Maglie <c.maglie@arduino.cc> Co-authored-by: Silvano Cerza <silvanocerza@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)If a folder meant to contain precompiled libraries is empty (or only contains other folders) it can be safely skipped
The folder is not skipped, so libraries with
src/$architecture/$fp_specs
will try to usesrc/$architecture/
as precompiled base folder, even if it doesn't contain any libraryThe folder is skipped and the library can be compiled from sources
titled accordingly?
See how to contribute