Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to export binaries if --only-compilation-database is set #1181

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 10, 2021

Otherwise an empty build/fqbn/... folder is created if always-export-binaries option is set via config file.

@cmaglie cmaglie self-assigned this Feb 10, 2021
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an integration test to verify this new behaviour, the rest looks good.

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the latest build and LS operations will not create the build folder.
Works fine

cmaglie and others added 3 commits February 11, 2021 15:50
otherwise an empty "build/fqbn/..." folder is created if "always-export-binaries"
option is set via config file.
@silvanocerza silvanocerza force-pushed the do_not_export_for_compile_commands_only branch from b4cc692 to b74ab17 Compare February 11, 2021 15:11
@silvanocerza
Copy link
Contributor

Rebased to fix conflicts.

@silvanocerza silvanocerza merged commit fb30f2d into arduino:master Feb 11, 2021
@cmaglie cmaglie deleted the do_not_export_for_compile_commands_only branch February 15, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants