Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a regression introduced in #be5022e. --input flags were ignored #1558

Merged
merged 3 commits into from
Nov 22, 2021
Merged

fix a regression introduced in #be5022e. --input flags were ignored #1558

merged 3 commits into from
Nov 22, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 19, 2021

partially revert "refactor sketch path calculation" in upload.go

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

fix regression

  • What is the current behavior?

The test test/test_upload.py::test_upload_with_input_dir_flag was failing

  • What is the new behavior?

fixed the regression introduced by reverting a change made in #1542

no

  • Other information:

See how to contribute

@umbynos umbynos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface labels Nov 19, 2021
@umbynos umbynos requested a review from a team November 19, 2021 17:51
@umbynos umbynos self-assigned this Nov 19, 2021
per1234
per1234 requested changes Nov 21, 2021
View reviewed changes
cli/upload/upload.go Outdated Show resolved Hide resolved
@umbynos umbynos changed the title fix a regression introduced in #be5022e0. --input flags were ignored fix a regression introduced in be5022e07cdfa9398c9fc035b8605009193f4f81. --input flags were ignored Nov 22, 2021
@umbynos umbynos changed the title fix a regression introduced in be5022e07cdfa9398c9fc035b8605009193f4f81. --input flags were ignored fix a regression introduced in #be5022e. --input flags were ignored Nov 22, 2021
@umbynos umbynos merged commit 89dbd25 into master Nov 22, 2021
@umbynos umbynos deleted the umbynos/fix_input_flags branch November 22, 2021 13:20
umbynos added a commit that referenced this pull request Nov 22, 2021
@umbynos
fix a regression introduced in #be5022e. --input flags were ignored (…
750e914 
…#1558)

* fix a regression introduced in be5022e. `--input` flags were ignored
partially revert "refactor sketch path calculation" in `upload.go`

* fix test after f85513c

* use `WarnDeprecatedFiles` to remove some code duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 requested changes

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees

@umbynos umbynos

Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umbynos @silvanocerza @per1234