Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip flag to daemon command #1651

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Add ip flag to daemon command #1651

merged 1 commit into from
Feb 3, 2022

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Feb 3, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Adds a new flag to an existing command.

  • What is the current behavior?

A user running daemon has no way of setting a custom IP.

  • What is the new behavior?

A user can now use the --ip flag to use a custom IP to listen for gRPC requests.

Nope.

  • Other information:

This flag was also introduced in #1622 but it won't be merged into master until the whole configs migration is finished.
Since this is small change and has been asked by the community we decided it was worth releasing it before the whole configs migration.


See how to contribute

@silvanocerza silvanocerza added the type: enhancement Proposed improvement label Feb 3, 2022
@silvanocerza silvanocerza self-assigned this Feb 3, 2022
@silvanocerza
Copy link
Contributor Author

@4ntoine #1622 won't be released for the time being so I made this new PR to set a custom IP.

@silvanocerza silvanocerza merged commit 200d4b4 into master Feb 3, 2022
@silvanocerza silvanocerza deleted the scerza/custom-ip branch February 3, 2022 09:54
@per1234 per1234 added topic: CLI Related to the command line interface topic: code Related to content of the project itself labels Feb 5, 2022
@umbynos umbynos mentioned this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants