Skip to content

Fix error being printed in index parsing during first start #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix error being printed in index parsing during first start #1672

merged 1 commit into from
Feb 23, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 22, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Bug fix

  • What is the current behavior?

If index parsing on first start fails for some reason, the error is not correctly printed.

  • What is the new behavior?

The error gets printed

no

  • Other information:

See https://github.com/arduino/ArduinoCore-samd/runs/5286418366?check_suite_focus=true#step:7:300

See how to contribute

@umbynos umbynos added the type: imperfection Perceived defect in any part of project label Feb 22, 2022
@umbynos umbynos requested a review from a team February 22, 2022 11:24
@umbynos umbynos self-assigned this Feb 22, 2022
@per1234 per1234 added the topic: code Related to content of the project itself label Feb 22, 2022
@umbynos umbynos merged commit 2f2cbe2 into master Feb 23, 2022
@umbynos umbynos deleted the umbynos/fix_error_printing branch February 23, 2022 10:46
silvanocerza pushed a commit that referenced this pull request Feb 23, 2022
@umbynos @silvanocerza
fix error being printed in index parsing during first start (#1672)
9fcbb39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @cmaglie @per1234