Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Add hooks hooks.savehex.presavehex and hooks.savehex.postsavehex #2091

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Code enhancement

What is the current behavior?

There is currently no support for hooks.savehex.presavehex and hooks.savehex.postsavehex.

What is the new behavior?

hooks.savehex.presavehex and hooks.savehex.postsavehex run if exportBinaries if set to true.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 28, 2023
@MatteoPologruto MatteoPologruto self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (78bfa74) 36.43% compared to head (cb82028) 36.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
- Coverage   36.43%   36.42%   -0.02%     
==========================================
  Files         229      229              
  Lines       19578    19586       +8     
==========================================
  Hits         7134     7134              
- Misses      11606    11614       +8     
  Partials      838      838              
Flag Coverage Δ
unit 36.42% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/compile/compile.go 0.00% <0.00%> (ø)
commands/lib/search.go 88.15% <0.00%> (-3.95%) ⬇️
arduino/cores/packagemanager/package_manager.go 68.19% <0.00%> (+0.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos merged commit 5f73378 into arduino:master Mar 3, 2023
@MatteoPologruto MatteoPologruto deleted the savehex-hooks branch August 30, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hooks hooks.savehex.presavehex and hooks.savehex.postsavehex
4 participants