Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow build-path to be in a different drive than current sketch #2163

Merged
merged 1 commit into from
May 2, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 28, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This issue is mainly seen on Windows.

What is the current behavior?

(copied from original issue: #2156)

$ arduino-cli sketch new "e:/FooSketch"
Sketch created in: e:\FooSketch

$ arduino-cli compile --build-path "c:/Users/per/AppData/Local/Temp/build-path" --fqbn arduino:avr:uno "e:/FooSketch"
Error during build: Cannot find build path: Rel: can't make c:\Users\per\AppData\Local\Temp\build-path relative to E:\FooSketch

What is the new behavior?

Compiles succeed as expected.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

The actual patch is here: arduino/go-paths-helper#20

Fix #2156

@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: build-process Related to the sketch build process labels Apr 28, 2023
@cmaglie cmaglie self-assigned this Apr 28, 2023
@cmaglie cmaglie changed the title fix: Allow build-path to different drive than the sketch fix: Allow build-path to be in a different drive than current sketch Apr 28, 2023
@cmaglie cmaglie force-pushed the fix-build-on-different-drives branch from 5ace34f to 6836ad6 Compare April 28, 2023 15:59
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.02 🎉

Comparison is base (ad9ddb8) 62.49% compared to head (6836ad6) 62.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
+ Coverage   62.49%   62.51%   +0.02%     
==========================================
  Files         223      223              
  Lines       19472    19462      -10     
==========================================
- Hits        12169    12167       -2     
+ Misses       6205     6201       -4     
+ Partials     1098     1094       -4     
Flag Coverage Δ
unit 62.51% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/sketch/sketch.go 79.31% <0.00%> (ø)
commands/compile/compile.go 69.56% <50.00%> (+1.24%) ⬆️
arduino/cores/packagemanager/install_uninstall.go 54.42% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit 89368c9 into arduino:master May 2, 2023
@cmaglie cmaglie added this to the Arduino CLI 0.33.0 milestone May 2, 2023
@cmaglie cmaglie deleted the fix-build-on-different-drives branch May 5, 2023 14:43
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build-process Related to the sketch build process topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile command fails when sketch on different drive from custom build path
3 participants