Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed instance field in LoadSketch and NewSketch gRPC API #2215

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 14, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Remove not needed parameters in NewSketchRequest and LoadSketchRequest gRPC API

What is the current behavior?

What is the new behavior?

No change.

Does this PR introduce a breaking change, and is titled accordingly?

The API is backward compatible since the removed field was never used and has been marked as reserved.

Other information

See #2203 (comment) for more context

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Jun 14, 2023
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Jun 14, 2023
@cmaglie cmaglie self-assigned this Jun 14, 2023
@cmaglie cmaglie changed the title Remove not needed parameters in Sketch* related gRPC API Remove not needed instance field in LoadSketch and NewSketch gRPC API Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (5725c02) 62.98% compared to head (9529b2c) 62.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
- Coverage   62.98%   62.92%   -0.07%     
==========================================
  Files         218      218              
  Lines       19466    19465       -1     
==========================================
- Hits        12261    12248      -13     
- Misses       6122     6131       +9     
- Partials     1083     1086       +3     
Flag Coverage Δ
unit 62.92% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/cli/sketch/new.go 93.47% <ø> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Do clients still have to initialize the ArduinoCoreClient (and load the runtime tools, platforms, etc. then wait) before a NewSketchRequest or LoadSketchRequest?

@cmaglie
Copy link
Member Author

cmaglie commented Jun 15, 2023

Do clients still have to initialize the ArduinoCoreClient (and load the runtime tools, platforms, etc. then wait) before a NewSketchRequest or LoadSketchRequest?

No, it's not needed. It wasn't even before actually...

@cmaglie cmaglie merged commit d5fd94c into arduino:master Jun 15, 2023
93 checks passed
@cmaglie cmaglie deleted the remove_instance_from_sketch_commands branch June 15, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants