Skip to content

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Sep 6, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It should not produce visible user changes, it's a tentative factorization of the legacy arduino-builder code

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini self-assigned this Sep 6, 2023
@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 81.60% and project coverage change: +0.44% 🎉

Comparison is base (1c110e9) 63.37% compared to head (f57fbeb) 63.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2298      +/-   ##
==========================================
+ Coverage   63.37%   63.82%   +0.44%     
==========================================
  Files         214      214              
  Lines       19551    19794     +243     
==========================================
+ Hits        12390    12633     +243     
+ Misses       6075     6074       -1     
- Partials     1086     1087       +1     
Flag Coverage Δ
unit 63.82% <81.60%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legacy/builder/create_cmake_rule.go 8.30% <0.00%> (ø)
legacy/builder/test/helper.go 100.00% <ø> (+20.83%) ⬆️
legacy/builder/types/context.go 91.37% <ø> (-2.67%) ⬇️
legacy/builder/phases/sizer.go 44.11% <41.66%> (-1.45%) ⬇️
...der/wipeout_build_path_if_build_options_changed.go 78.84% <50.00%> (ø)
commands/compile/compile.go 71.42% <60.00%> (+0.08%) ⬆️
legacy/builder/phases/linker.go 80.23% <71.79%> (-2.05%) ⬇️
arduino/builder/utils/utils.go 76.49% <80.00%> (+7.64%) ⬆️
legacy/builder/phases/core_builder.go 77.77% <86.56%> (+6.22%) ⬆️
legacy/builder/phases/libraries_builder.go 80.37% <89.79%> (+4.05%) ⬆️
... and 7 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini force-pushed the refactor_legacy_phases branch 3 times, most recently from 846cf54 to dd83ffd Compare September 7, 2023 12:29
@cmaglie cmaglie added the type: enhancement Proposed improvement label Sep 8, 2023
@cmaglie cmaglie marked this pull request as ready for review September 8, 2023 09:59
@alessio-perugini alessio-perugini merged commit b8024c3 into master Sep 8, 2023
@alessio-perugini alessio-perugini deleted the refactor_legacy_phases branch September 8, 2023 11:53
@cmaglie cmaglie changed the title [skip-changelog] legacy: Builder refactorization (part 2) legacy: Builder refactorization (part 2) Sep 8, 2023
@cmaglie cmaglie changed the title legacy: Builder refactorization (part 2) legacy: Builder refactorization (part 2...) Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants