Skip to content

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini changed the title [skip-changelog] Update golang 1.21.1 [skip-changelog] Update golang to 1.21.1 Sep 14, 2023
@alessio-perugini alessio-perugini self-assigned this Sep 14, 2023
@alessio-perugini alessio-perugini added topic: infrastructure Related to project infrastructure topic: code Related to content of the project itself labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: -0.02% ⚠️

Comparison is base (4c0d72e) 63.06% compared to head (da4697e) 63.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
- Coverage   63.06%   63.04%   -0.02%     
==========================================
  Files         200      200              
  Lines       19206    19206              
==========================================
- Hits        12112    12109       -3     
- Misses       6049     6051       +2     
- Partials     1045     1046       +1     
Flag Coverage Δ
unit 63.04% <93.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/builder/detector/detector.go 74.34% <ø> (ø)
arduino/builder/export_cmake.go 7.98% <ø> (ø)
arduino/builder/libraries.go 81.25% <ø> (ø)
...er/preprocessor/internal/ctags/ctags_has_issues.go 98.58% <ø> (ø)
internal/cli/arguments/post_install.go 54.54% <ø> (ø)
internal/cli/completion/completion.go 91.66% <ø> (ø)
internal/cli/lib/search.go 54.91% <0.00%> (ø)
internal/inventory/inventory.go 53.19% <ø> (ø)
arduino/builder/cpp/cpp.go 93.22% <100.00%> (ø)
arduino/builder/preprocessor/ctags.go 68.62% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini marked this pull request as ready for review September 15, 2023 06:31
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessio-perugini alessio-perugini force-pushed the bye_bye_legacy branch 2 times, most recently from 9c073c1 to 99ccfb5 Compare September 15, 2023 16:10
Base automatically changed from bye_bye_legacy to master September 15, 2023 17:38
@alessio-perugini alessio-perugini merged commit 55fc5aa into master Sep 15, 2023
@alessio-perugini alessio-perugini deleted the update-golang-1-21-1 branch September 15, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants