Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Removed gRPC 'debug' service in favor of 'commands' service #2349

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 29, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

The gRPC service cc.arduino.cli.debug.v1 has been removed and all gRPC messages and rpc calls have been moved to cc.arduino.cli.commands.v1.

The gRPC message DebugConfigRequest has been renamed to the proper GetDebugConfigRequest.

All the generated API has been updated as well.

What is the current behavior?

No changes.

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Yes

Other information

@cmaglie cmaglie self-assigned this Sep 29, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Sep 29, 2023
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Sep 29, 2023
@cmaglie cmaglie force-pushed the remove_grpc_debug_service branch 2 times, most recently from 81e09fd to 49a0db4 Compare September 29, 2023 11:21
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6aa1be0) 63.04% compared to head (1a9dc04) 63.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
+ Coverage   63.04%   63.12%   +0.08%     
==========================================
  Files         201      201              
  Lines       19259    19255       -4     
==========================================
+ Hits        12141    12155      +14     
+ Misses       6064     6051      -13     
+ Partials     1054     1049       -5     
Flag Coverage Δ
unit 63.12% <38.46%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
commands/debug/debug_info.go 54.05% <100.00%> (ø)
internal/cli/daemon/daemon.go 48.51% <ø> (-1.49%) ⬇️
internal/cli/debug/debug.go 68.13% <100.00%> (ø)
commands/daemon/debug.go 0.00% <0.00%> (ø)
commands/debug/debug.go 41.02% <16.66%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! IDE2 does not use the gRPC API for debug

@cmaglie cmaglie merged commit c506f6a into arduino:master Oct 2, 2023
101 checks passed
@cmaglie cmaglie deleted the remove_grpc_debug_service branch October 2, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants