Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Failed to install arduino-cli" when invoked by install.sh #2380

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

brentru
Copy link
Contributor

@brentru brentru commented Oct 20, 2023

Due to PR #2374, install.sh fails to run on the latest release tag:

curl -fsSL https://raw.githubusercontent.com/arduino/arduino-cli/master/install.sh | sh
Installing in [dir]
ARCH=64bit
OS=macOS
Using curl as download tool
Failed to install arduino-cli

In turn, this causes repositories that have automated tooling and rely upon install.sh (such as adafruit/ci-arduino) to fail.

This pull request implements a fix suggested by @tobozo in #2370 because the v? prefix requires escaping to be passed to grep.

cc @cmaglie @per1234

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@alessio-perugini alessio-perugini merged commit b82a519 into arduino:master Oct 20, 2023
1 check passed
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Oct 20, 2023
@jhunji1701
Copy link

Hi

It seems like this issue has been fixed, but I have a new raspberry pi that I setup today, and I am running into the same issue.

cd /usr/local && sudo curl -fsSL https://raw.githubusercontent.com/arduino/arduino-cli/master/install.sh | sudo sh
Installing in /usr/local/bin
ARCH=ARMv7
OS=Linux
Using curl as download tool
Downloading https://downloads.arduino.cc/arduino-cli/arduino-cli_0.34.2_Linux_ARMv7.tar.gz
Failed to install arduino-cli

any advice would be much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants