Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugging requires a non empty debug.executable #2439

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

pillo79
Copy link
Contributor

@pillo79 pillo79 commented Nov 27, 2023

Allow debugger to be disabled in case debug.executable property is undefined OR defined as the empty string.
Previously the debugger was disabled only if undefined.

@cmaglie cmaglie self-assigned this Nov 27, 2023
@cmaglie cmaglie added this to the Arduino CLI v0.35.0 milestone Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0381aa5) 67.33% compared to head (99c3ea8) 67.32%.

❗ Current head 99c3ea8 differs from pull request most recent head 6518e5a. Consider uploading reports for the commit 6518e5a to get more accurate results

Files Patch % Lines
commands/debug/debug_info.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2439      +/-   ##
==========================================
- Coverage   67.33%   67.32%   -0.02%     
==========================================
  Files         210      210              
  Lines       20591    20591              
==========================================
- Hits        13865    13862       -3     
- Misses       5586     5588       +2     
- Partials     1140     1141       +1     
Flag Coverage Δ
unit 67.32% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit ab03161 into arduino:master Nov 27, 2023
97 of 98 checks passed
cmaglie added a commit to cmaglie/arduino-cli that referenced this pull request Dec 20, 2023
* fix: debugging requires a non empty debug.executable

* Updated docs

---------

Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants