Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify the config file through ARDUINO_CONFIG_FILE env #2488

Merged

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Add ARDUINO_CONFIG_FILE env var, which as the same behaviour of the --config-file flag.

What is the current behavior?

Currently an user can only specify a specifc config file through the usage of --config-file flag.
It's not possible to specify the config file thorugh an env var.

What is the new behavior?

Adding the ARDUINO_CONFIG_FILE is now possible to specify either a specifc config file or a directory
containing the default configuration file.
If the cli is provied with both --config-file and the new env the flag takes precedence.

Does this PR introduce a breaking change, and is titled accordingly?

no

Other information

@alessio-perugini alessio-perugini linked an issue Jan 4, 2024 that may be closed by this pull request
3 tasks
@alessio-perugini alessio-perugini self-assigned this Jan 4, 2024
@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 4, 2024
@alessio-perugini alessio-perugini added this to the Arduino CLI v0.36.0 milestone Jan 4, 2024
@alessio-perugini alessio-perugini marked this pull request as ready for review January 4, 2024 12:09
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dbd871) 68.83% compared to head (863dd62) 68.91%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   68.83%   68.91%   +0.07%     
==========================================
  Files         204      204              
  Lines       20465    20465              
==========================================
+ Hits        14088    14104      +16     
+ Misses       5222     5211      -11     
+ Partials     1155     1150       -5     
Flag Coverage Δ
unit 68.91% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini merged commit 95753fc into master Jan 4, 2024
200 checks passed
@alessio-perugini alessio-perugini deleted the 2481-support-arduino_config-environment-variable-1 branch January 4, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ARDUINO_CONFIG environment variable
2 participants