Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Add protoc oneof clause where appropriate. #2608

Merged
merged 5 commits into from
May 16, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 16, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Add protoc oneof clause where appropriate.

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Yes.

Other information

Fix #2593

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels May 16, 2024
@cmaglie cmaglie self-assigned this May 16, 2024
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤩

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 70.26%. Comparing base (8b78c05) to head (8290196).

Files Patch % Lines
commands/service_debug_run.go 0.00% 12 Missing ⚠️
commands/service_debug.go 0.00% 5 Missing ⚠️
commands/service_monitor.go 33.33% 3 Missing and 1 partial ⚠️
commands/service_library_uninstall.go 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
+ Coverage   70.11%   70.26%   +0.14%     
==========================================
  Files         222      222              
  Lines       21124    21262     +138     
==========================================
+ Hits        14812    14939     +127     
- Misses       5135     5147      +12     
+ Partials     1177     1176       -1     
Flag Coverage Δ
unit 70.26% <86.95%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit b0cc1a9 into arduino:master May 16, 2024
104 checks passed
@cmaglie cmaglie deleted the grpc_oneof branch May 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC: Use oneof clause where appropriate
2 participants