Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC: Added progress callback in CompileServerToStreams adapter #2623

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 5, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

I forget to report progress in the gRPC API adapter.

What is the current behavior?

No changes, just an API improvement

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No, because it's already part of a breaking change that has not been released yet.

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 5, 2024
@cmaglie cmaglie self-assigned this Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (81d517b) to head (3d074c6).
Report is 1 commits behind head on master.

Files Patch % Lines
commands/service_compile.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2623      +/-   ##
==========================================
- Coverage   70.30%   70.29%   -0.01%     
==========================================
  Files         222      222              
  Lines       21304    21308       +4     
==========================================
+ Hits        14977    14978       +1     
- Misses       5151     5153       +2     
- Partials     1176     1177       +1     
Flag Coverage Δ
unit 70.29% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit b16ae70 into arduino:master Jun 5, 2024
98 checks passed
@cmaglie cmaglie deleted the grpc_small_fix branch June 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants