Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration: env vars with array values rendered as a single string #2644

Closed
wants to merge 2 commits into from

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Jun 18, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix a regression in passing multiple values to a single env var that wasn't correctly expanded.

What is the current behavior?

When passing multiple values in a single env var, they are rendered a single string, causing unexpected behaviors.

What is the new behavior?

Now we treat such values as multiple values and not as a single string. We split them by whitespace.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini self-assigned this Jun 18, 2024
@alessio-perugini alessio-perugini added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 18, 2024
@alessio-perugini alessio-perugini marked this pull request as ready for review June 18, 2024 08:33
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (3f0d43f) to head (651c32e).
Report is 3 commits behind head on master.

Current head 651c32e differs from pull request most recent head 6e7613b

Please upload reports for the commit 6e7613b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2644      +/-   ##
==========================================
+ Coverage   70.29%   70.31%   +0.02%     
==========================================
  Files         222      222              
  Lines       21308    21318      +10     
==========================================
+ Hits        14978    14990      +12     
+ Misses       5153     5151       -2     
  Partials     1177     1177              
Flag Coverage Δ
unit 70.31% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini
Copy link
Contributor Author

superseeded by #2645

@cmaglie cmaglie deleted the fix-26-43 branch June 18, 2024 08:57
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to configure multiple URLs via ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS
2 participants