Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pluggable-discovery-protocol-handler library #2707

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 13, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Updates the pluggable-discovery client library.

What is the current behavior?

In some circumstances the pluggable-discovery client panics (in particular if the discovery crashes on startup).

What is the new behavior?

The crashing discovery is handled gracefully.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Upstream fix arduino/pluggable-discovery-protocol-handler#50
Fix #2665

@cmaglie cmaglie marked this pull request as draft September 13, 2024 12:54
@cmaglie cmaglie self-assigned this Sep 13, 2024
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (23d5036) to head (d57a042).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2707   +/-   ##
=======================================
  Coverage   67.67%   67.68%           
=======================================
  Files         234      234           
  Lines       22207    22285   +78     
=======================================
+ Hits        15028    15083   +55     
- Misses       5998     6017   +19     
- Partials     1181     1185    +4     
Flag Coverage Δ
unit 67.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 1b889a6 into arduino:master Oct 7, 2024
99 checks passed
@cmaglie cmaglie deleted the update_pl_disc_lib branch October 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arduino CLI panics when pluggable discovery tool crashes
2 participants