Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the serial discovery execution atomic #365

Merged
merged 4 commits into from Aug 28, 2019
Merged

Make the serial discovery execution atomic #365

merged 4 commits into from Aug 28, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 28, 2019 •
edited

Attempt to fix a concurrency issue surfacing when multiple clients at once use the CLI from the gRPC Api. Instead of having the client code calling Start, List and Close in sequence, we only export List that will take care of the entire workflow.

@masci masci added the status: on hold Do not proceed at this time label Aug 28, 2019
rsora
rsora approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Also the 10s timeout makes sense to me as we have users that could run our software in very old or peculiar hosts.

@masci masci removed the status: on hold Do not proceed at this time label Aug 28, 2019
@masci masci merged commit 3a71131 into master Aug 28, 2019
@masci masci deleted the massi/sync branch August 28, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masci @rsora