Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] Upload coverage only on push events #375

Merged
merged 1 commit into from Aug 29, 2019
Merged

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 29, 2019

Workflows run on PRs coming from forks are currently broken.

Since secrets aren't available on forks, we only upload coverage on push. This might change if Codecov whitelists GitHub, lifting the need for a token.

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit 5e1627d into master Aug 29, 2019
@masci masci deleted the massi/pushonly branch August 29, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants