Add gRPC interface to CLI settings #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirropirro
approved these changes
Dec 17, 2019
rsora
pushed a commit
that referenced
this pull request
Dec 19, 2019
* define proto messages and service * run protoc on settings interface, regenerate code * add service implementation and tests * remove test leftovers
This was referenced Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to get and set settings value from the gRPC interface. CLI settings are key/value pairs with keys of type string and values that can be arbitrary values. To keep the gRPC interface generic, we'll be exchanging settings values as JSON serialized data that's stored in proto messages as strings.