lib install command will exit with non-zero status code if library dependency could not be resolved #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdiniz
changed the title
cmaglie
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix. Return non-zero exit code if library install fails due to dependency resolution.
Fixes arduino-cli lib install has exit status 0 when library is not found #712
What is the current behavior?
Failure to resolve library dependency is logged, but does not exit with non-zero status code to indicate the error.
What is the new behavior?
If it is not possible to resolve the dependency of a library, the error is logged and the process exits with an error code.
Does this PR introduce a breaking change?
The lib install command will now exit with a non-zero code if a library dependency cannot be resolved.
Other information:
See how to contribute