fix: trailing FQBN part if there are no configs

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
arduino · Jun 27, 2023 · 2473435 · 2473435
1 parent b0422a7
commit 2473435
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/arduino-ide-extension/src/common/protocol/boards-service.ts b/arduino-ide-extension/src/common/protocol/boards-service.ts
@@ -574,7 +574,8 @@ export namespace ConfigOption {
     const configSuffix = Object.entries(mergedOptions)
       .map(([option, value]) => `${option}=${value}`)
       .join(',');
-    return `${vendor}:${arch}:${id}:${configSuffix}`;
+
+    return `${vendor}:${arch}:${id}${configSuffix ? `:${configSuffix}` : ''}`;
   }
 
   export class ConfigOptionError extends Error {

diff --git a/arduino-ide-extension/src/test/common/boards-service.test.ts b/arduino-ide-extension/src/test/common/boards-service.test.ts
@@ -104,6 +104,12 @@ describe('boards-service', () => {
         })
     );
 
+    it('should not append the trailing boards config part to FQBN if configs is empty', () => {
+      const fqbn = 'a:b:c';
+      const actual = ConfigOption.decorate(fqbn, []);
+      expect(actual).to.be.equal(fqbn);
+    });
+
     it('should be noop when config options is empty', () => {
       const fqbn = 'a:b:c:menu1=value1';
       const actual = ConfigOption.decorate(fqbn, []);