Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close compilation/upload error notifications on subsequent actions #1154

Closed
3 tasks done
per1234 opened this issue Jul 8, 2022 · 0 comments · Fixed by #1275
Closed
3 tasks done

Close compilation/upload error notifications on subsequent actions #1154

per1234 opened this issue Jul 8, 2022 · 0 comments · Fixed by #1275
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Jul 8, 2022

Describe the request

Automatically close compilation and upload error notifications when a subsequent compilation or upload is triggered.

🙂 The user will only be presented with relevant notifications.

Describe the current behavior

The Arduino IDE opens a notification when compilation or upload of a sketch fails. This is an excellent way of supplementing the more verbose and cryptic error messages shown in the "Output" view.

Although very valuable in the time after a failed compilation or upload, this notification is no longer relevant when a subsequent compilation/upload is triggered, since at that point the user is only interested in what the result will be of the current operation.

Currently, the notifications of errors from previous compilations/uploads are retained until the user manually closes them, which some might not think to do.

  1. Create a sketch that will fail to compile:

    #error
    void setup() {}
    void loop() {}
  2. Select Sketch > Verify/Compile from the Arduino IDE menus.

  3. Wait for compilation to finish.
    🙂 A notification clearly communicates that there was a compilation error:

    ❌ Compilation error: #error

  4. Fix the problem with the sketch:

    void setup() {}
    void loop() {}
  5. Select Sketch > Verify/Compile from the Arduino IDE menus.

  6. Wait for compilation to finish.
    There are now two notifications, shown in this order:

    ⓘ Done Compiling

    ❌ Compilation error: #error

The "Done Compiling" notification does not clearly indicate a successful result. It also disappears after 3 seconds while the "Compilation error" notification is persistent.

🙁 It may not be clear to the user that the current compilation or upload was successful.

This is what the IDE looks like at the completion of a successful upload following some expected struggles:

image

Arduino IDE version

2.0.0-rc8-snapshot-1073c3f

Operating system

Windows

Operating system version

10

Additional context

Originally reported at https://forum.arduino.cc/t/imperfection-improvement/1010339

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 8, 2022
@kittaakos kittaakos self-assigned this Aug 11, 2022
kittaakos pushed a commit that referenced this issue Aug 11, 2022
Closes #1154

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Aug 11, 2022
Closes #1154

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Aug 11, 2022
Closes #1154

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Aug 15, 2022
Closes #1154

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants