Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar width non-standard #436

Open
tomotvos opened this issue Jul 6, 2021 · 2 comments
Open

Scrollbar width non-standard #436

tomotvos opened this issue Jul 6, 2021 · 2 comments
Assignees
Labels
topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project

Comments

@tomotvos
Copy link

tomotvos commented Jul 6, 2021

Describe the problem

The width of the scroll bar in the editor panel is too narrow.

To reproduce

  1. Edit a sketch with more than a full screen of lines

Scroll bar appears roughly half the width it should be.

Here you can see it compared against the width of the Chrome browser scrollbar:

image

Expected behavior

The scroll bar should be the standard size for each platform

Arduino IDE version

Original report

2.0.0-beta.8

Last verified with

e17472e

Operating system

macOS

Operating system version

Big Sur

Additional context

Additional reports

@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 24, 2021
@per1234 per1234 changed the title Scroll bar width non-standard Scrollbar width non-standard Nov 6, 2022
@per1234
Copy link
Contributor

per1234 commented Nov 7, 2022

The Theia developers set this non-standard width without providing any justification for doing so:

eclipse-theia/theia#852

The scrollbar width is intended to be configurable, but unfortunately the non-standard width was configured in such a way that causes that configuration to be ignored:

eclipse-theia/theia#11732

My hope is that the bug can be resolved in Theia. If that ends up not being possible, I think it will be important for Arduino to investigate whether there is a way to patch it from the Arduino IDE codebase and ideally to also set the default width in Arduino IDE to the same width as the scrollbar in every non-Theia application ever made.

@per1234 per1234 added the topic: theia Related to the Theia IDE framework label Nov 7, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 1, 2023

The fix for eclipse-theia/theia#11732 was released in Theia 1.33.0. It was introduced into this project via #2027

So the resolution of this defect is now be possible simply by setting the default values of the editor.scrollbar.horizontalScrollbarSize and editor.scrollbar.verticalScrollbarSize settings to 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

5 participants