Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support updates in lib/boards widget #1963

Closed
wants to merge 3 commits into from
Closed

feat: support updates in lib/boards widget #1963

wants to merge 3 commits into from

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 15, 2023 •
edited

Motivation

To enhance the libraries and the boards management.

Restore view state:

1963__restore_state.mp4

Show updates count on the side-bar:

1963__updates_count.mp4

New filter UX:

Screen Shot 2023-03-15 at 21 36 11

Hover for libraries and platforms:

1963__hover.mp4

Change description

Other information

  • Thanks for the excellent work for @msujew's hover service in Theia. I have shamelessly copied his work as-is from the Theia repository. I wanted to exclude a Theia version update in this PR.
  • Thanks for the input for @nmzaheer spotting the incorrect library paragraph and sentence order months ago in his PR.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos self-assigned this Mar 15, 2023
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 15, 2023
Akos Kitta added 3 commits March 16, 2023 10:03
feat: support updates in lib/boards widget
fa4626b 
 - can show badge with updates count,
 - better hover for libraries and platforms,
 - save/restore widget state (Closes arduino#1398),
 - fixed `sentence` and `paragraph` order (Ref arduino#1611)

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
fix: no group for the description if it's missing
0335590 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
fix: relaxed hover service request when scrolling
5c31c93 
 - do not render footer when scrolling
 - fix anchor word wrapping for long long links in the markdown
 - underline the link and change the cursor to pointer on hover
 - consider status-bar height when calculating hover top

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos removed their assignment Feb 23, 2024
@kittaakos kittaakos mentioned this pull request Feb 23, 2024
Draft
4 tasks
@kittaakos
Copy link
Contributor Author

Duplicate of #2384.

@kittaakos kittaakos closed this Feb 23, 2024
@kittaakos kittaakos added the conclusion: duplicate Has already been submitted label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore filter in library and boards manager view between app stop/start
1 participant
@kittaakos