Skip to content

fix: incorrect certificate flashing command string #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2023
Merged

fix: incorrect certificate flashing command string #2181

merged 2 commits into from
Aug 20, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

Fix the certificate flashing.

Change description

Use a string array of command flags instead of the concatenated final string command.

Other information

Ref: #2067

Closes #2179

I could reproduce and fix the defect, but the certificate flashing failed with the Error: missing ack on erase: ab familiar error:

Error executing /Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/resources/arduino-fwuploader certificates flash -b arduino:mbed_nano:nanorp2040connect -a /dev/cu.usbmodem14301 -u arduino.cc:443: Error: missing ack on erase: ab Error: Error executing /Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/resources/arduino-fwuploader certificates flash -b arduino:mbed_nano:nanorp2040connect -a /dev/cu.usbmodem14301 -u arduino.cc:443: Error: missing ack on erase: ab

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: incorrect certificate flashing command string
ab9490d 
Use a `string` array of command flags instead of the concatenated final
`string` command.

Ref: #2067

Closes #2179

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 20, 2023
@kittaakos kittaakos self-assigned this Aug 20, 2023
per1234
per1234 approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2179

Thanks Akos!

@kittaakos kittaakos merged commit 9a99957 into main Aug 20, 2023
@kittaakos kittaakos deleted the #2179 branch August 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL root certificate upload fails: "Error during firmware flashing: missing board address"
2 participants
@kittaakos @per1234