Skip to content

ATL-1151: settings panel to reflect actual state #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

ATL-1151: settings panel to reflect actual state #286

merged 1 commit into from
Mar 31, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Mar 29, 2021 •
edited
Loading

Motivation

We want the settings preference panel to reflect the actual state of the application. Even if command palette commands change the status bypassing the preference panel UI.

Change description

  • reload the preference before opening the preference panel dialog

Additional Notes

Jira task

Demo:

Screen.Recording.2021-03-29.at.16.12.24.mov

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • History is clean, commit messages are meaningful.

@fstasi fstasi requested a review from kittaakos March 29, 2021 14:14
kittaakos
kittaakos approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise, it looks good. Thank you! 👍

Please merge only if you have the final approval from an Arduino member.

@fstasi fstasi merged commit d45dd6b into main Mar 31, 2021
@Mammad900 Mammad900 mentioned this pull request Apr 4, 2021
Closed
@kittaakos kittaakos deleted the atl-1151--theme-preferences branch April 8, 2021 12:42
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@kittaakos kittaakos kittaakos approved these changes

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fstasi @kittaakos @rsora @per1234