Skip to content

Commit b40d67b

Browse files
umbynosper1234
andauthored
Apply suggestions from code review
Co-authored-by: per1234 <accounts@perglass.com>
1 parent 1262a6f commit b40d67b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/release.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ jobs:
106106
- name: Upload artifacts
107107
uses: actions/upload-artifact@v3
108108
with:
109+
if-no-files-found: error
109110
name: ${{ env.ARTIFACT_NAME }}
110111
path: ${{ env.PROJECT_NAME }}/${{ env.PROJECT_NAME }}_*
111112

@@ -162,7 +163,7 @@ jobs:
162163
# This step performs the following:
163164
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
164165
run: |
165-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
166+
# GitHub's upload/download-artifact actions don't preserve file permissions,
166167
# so we need to add execution permission back until the action is made to do this.
167168
chmod +x ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_macOS_64bit/bin/${{ env.PROJECT_NAME }}
168169
TAG="${GITHUB_REF/refs\/tags\//}"
@@ -182,7 +183,7 @@ jobs:
182183
needs: [build, notarize-macos]
183184

184185
steps:
185-
- name: Checkout avrdude repository # we need package_index.template
186+
- name: Checkout repository # we need package_index.template
186187
uses: actions/checkout@v3
187188

188189
- name: Download artifact
@@ -200,7 +201,7 @@ jobs:
200201
unzip -p /tmp/3.2.0.zip semver-tool-3.2.0/src/semver >/tmp/semver && chmod +x /tmp/semver
201202
if [[ "$(/tmp/semver get prerel "${GITHUB_REF/refs\/tags\//}")" ]]; then echo "::set-output name=IS_PRE::true"; fi
202203
203-
- name: Prepare artifacts for the release and handle package_index
204+
- name: Generate package index entry
204205
run: |
205206
TAG=${GITHUB_REF/refs\/tags\//}
206207
package_index=`cat package_index.template | sed s/%%VERSION%%/${TAG}/`
@@ -212,7 +213,7 @@ jobs:
212213
T_OS=`echo ${folder} | awk '{print toupper($0)}'`
213214
SHASUM=`sha256sum ${ARCHIVE_NAME} | cut -f1 -d" "`
214215
SIZE=`stat --printf="%s" ${ARCHIVE_NAME}`
215-
package_index=`echo $package_index |
216+
package_index=`echo "$package_index" |
216217
sed s/%%FILENAME_${T_OS}%%/${ARCHIVE_NAME}/ |
217218
sed s/%%FILENAME_${T_OS}%%/${ARCHIVE_NAME}/ |
218219
sed s/%%SIZE_${T_OS}%%/${SIZE}/ |

0 commit comments

Comments
 (0)