Skip to content

Conversation

jcarolinares
Copy link
Contributor

What This PR Changes

  • History revision sections updated

Contribution Guidelines

@jcarolinares jcarolinares requested a review from jhansson-ard May 18, 2023 12:38
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 18, 2023

✅ docs-content deploy preview ready

Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments 🙏🏼

@jcarolinares jcarolinares changed the title History sections of datasheets updated with the right format [PC-1250] History sections of datasheets updated with the right format May 25, 2023
Josefine's suggestions commited

Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@jcarolinares
Copy link
Contributor Author

This is the reason we do reviews. My mind was clearly in another place and I missed some important things.

Thank you @jhansson-ard now is perfect <3

Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@jcarolinares jcarolinares merged commit b98b83f into main May 25, 2023
@jcarolinares jcarolinares deleted the jcarolinares/datasheets/revision_history_dates_format branch May 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants