Skip to content

Conversation

inalkm
Copy link
Contributor

@inalkm inalkm commented Jun 23, 2023

Under the Deploy heading, the trained model is being created as a library option, not firmware. Because later in the following steps, it is the library that is created by EdgeImpulse that is being implemented into the forked firmware at OpenMV github. Thank you.

What This PR Changes

Under the Using the ML Model > Deploy heading on this page, the third sentence reads, '...OpenMV under "Build firmware" and click "build"', which I think needs to state '...OpenMV under "Create Library" and click "build"'. Because in the following steps on this page, it is the exported library from Edge Impulse that is being integrated to a new firmware build on OpenMV github. Now, EdgeImpulse does provide the option to create a firmware as well, but that is not the method that is followed here if I am understanding right. Thank you.

Contribution Guidelines

Under the Deploy heading, the trained model is being created as a library option, not firmware. Because later in the following steps, it is the library that is created by EdgeImpulse that is being implemented into the forked firmware at OpenMV github. Thank you.
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2023

CLA assistant check
All committers have signed the CLA.

@jhansson-ard jhansson-ard added the community Bugs and fixes suggested by the community label Jun 29, 2023
@sebromero
Copy link
Contributor

Actually the tutorial is quite outdated and needed a bit of an overhaul. I made the changes already and I'm closing this PR in favor of #1234
Thank you @inalkm for spotting this!

@sebromero sebromero closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants