[MKC-1011] [UNO R4 WiFi] VRTC & Off Pin tutorial #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ docs-content deploy preview ready
|
karlsoderby
previously requested changes
Jul 6, 2023
There was a problem hiding this comment.
@jacobhylen great start, but I think we need to address the following:
- for the VRTC pin, I think we need to show an example sketch. RTC examples have a
startTime()initiated when the board starts, so this will probably overwrite the current time. If the purpose is to keep the time during power off, we need to show a method of obtaining it after re-launch. - circuit with batteries needs just a label on which pins we are connecting to.
- a circuit / render that shows precisely how to short GND with OFF (like this one).
- (optional) create a circuit with a power switch connected to OFF pin.
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/vrtc-off/vrtc-off.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/vrtc-off/vrtc-off.md
Outdated
Show resolved
Hide resolved
Co-authored-by: BenjaminDannegard <b.dannegard@arduino.cc>
jacobhylen
dismissed
karlsoderby’s stale review
Adressed but you're not here to re-review :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines