Skip to content

[MKC-1261] Update RTC examples #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

[MKC-1261] Update RTC examples #1445

merged 1 commit into from
Oct 27, 2023

Conversation

jacobhylen
Copy link
Contributor

@jacobhylen jacobhylen commented Oct 26, 2023 •
edited
Loading

What This PR Changes

  • Updates the alarm RTC examples for UNO R4 so that they:
    a) don't Serial.print() in the callback function
    b) Match the examples that are bundled in the core

Contribution Guidelines

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 26, 2023

✅ docs-content deploy preview ready

@jhansson-ard jhansson-ard added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team maker labels Oct 27, 2023
karlsoderby
karlsoderby approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you make a PR to the renesas core to change it as well?

@jacobhylen
Copy link
Contributor Author

That's where I got this code from :)

@jacobhylen jacobhylen merged commit 0dd7d88 into main Oct 27, 2023
@jacobhylen jacobhylen deleted the jacobhylen/updatertcexamples branch October 27, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlsoderby karlsoderby karlsoderby approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update maker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobhylen @karlsoderby @jhansson-ard