Skip to content

Fix typo StringReplace.md #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix typo StringReplace.md #1455

merged 1 commit into from
Nov 21, 2023

Conversation

s1050613
Copy link
Contributor

@s1050613 s1050613 commented Oct 31, 2023 •
edited
Loading

What This PR Changes

  • This PR removes the start of a line of an example code which implies that the String replace() function returns another String, whilst it returns void. When attempting to compile the code, an error is produced: Compilation error: conversion from 'void' to non-scalar type 'String' requested
  • Now, it correctly indicates that replace() returns nothing

Contribution Guidelines

@s1050613
Fix typo StringReplace.md
16f1821 
Replaced assignment which implied replace() returned a String
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community labels Nov 3, 2023
@karlsoderby karlsoderby merged commit f7820c8 into arduino:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlsoderby karlsoderby karlsoderby approved these changes

Assignees
No one assigned
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s1050613 @CLAassistant @karlsoderby @jhansson-ard