Skip to content

Conveyor Application Note Color Code Fix #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conveyor Application Note Color Code Fix #2211

merged 3 commits into from
Oct 3, 2024

Conversation

mcmchris
Copy link
Collaborator

@mcmchris mcmchris commented Oct 3, 2024 •
edited
Loading

What This PR Changes

  • Conveyor Application Note Color Code Fix

Contribution Guidelines

@mcmchris mcmchris requested a review from jcarolinares October 3, 2024 13:27
@mcmchris mcmchris self-assigned this Oct 3, 2024
jcarolinares
jcarolinares approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

still some things about genric signals that we need to decide together but AC and DC power lines are better color coded now, thanks @mcmchris for the corrections and @navalog for the feedback, merging!

@jcarolinares jcarolinares merged commit 5f83858 into main Oct 3, 2024
4 checks passed
@jcarolinares jcarolinares deleted the mcmchris/opta/conveyor-app-note-update-2 branch October 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarolinares jcarolinares jcarolinares approved these changes

Assignees

@mcmchris mcmchris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmchris @jcarolinares