Skip to content

CAT M1 datasheet fixes #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2022
Merged

CAT M1 datasheet fixes #93

merged 3 commits into from
Mar 30, 2022

Conversation

sebromero
Copy link
Contributor

This PR:

  • Moves the antenna connectors to the correct table (bottom view)
  • Replaces the pinout with one that outlines the text
  • Fixes the incorrect title of the pinout

What Needs To Be Reviewed

  • If the changed content is correct

How To Give Feedback

Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏

@sebromero sebromero requested a review from lunnea March 16, 2022 10:35
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 16, 2022

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 17m

@marqdevx marqdevx added fix/update A small fix or update Tutorial arduino Bugs and fixes added by the Arduino Team labels Mar 28, 2022
@sebromero sebromero requested a review from aliphys March 30, 2022 10:03
aliphys
aliphys approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@aliphys aliphys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero sebromero merged commit 5d50cdf into main Mar 30, 2022
@sebromero sebromero deleted the sebromero/catm1-datasheet-connectors branch March 30, 2022 11:29
marqdevx pushed a commit that referenced this pull request May 9, 2022
@aliphys
Merge pull request #93 from arduino/aliphys/maxCarrierH7X8Table
51a7b5a 
[TC-262] Add table for H7/X8 difference in Max Carrier DS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunnea lunnea Awaiting requested review from lunnea

1 more reviewer

@aliphys aliphys aliphys approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update Tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebromero @aliphys @marqdevx