Bump node from 16 to 20 #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@gdraynz thank you for taking care of this. Try to change the We have solved this with @per1234 in the https://github.com/arduino/setup-protoc |
|
Awesome, that did it thank you @alessio-perugini. |
alessio-perugini
approved these changes
Feb 1, 2024
|
@per1234 I've tested this in a private repo and it looks good. After merging this ideally, we should bump a major version to |
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are now being sent out due the deprecation of node16, node20 should be used for Github Actions.
This PR also update the
npm:validatetask based on @alessio-perugini's comment below.