Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Typo in HTML #1358

Closed
wants to merge 1 commit into from
Closed

Minor Typo in HTML #1358

wants to merge 1 commit into from

Conversation

reloxx13
Copy link
Contributor

No description provided.

arendst added a commit that referenced this pull request Dec 14, 2017
@arendst
Fix BME680 Pressure and minor HTNL optimizations
b07d622 
* Fix BME680 pressure data (#1356)
 * Minor webpage HTML optimizations
(#1358)
@arendst arendst closed this Dec 14, 2017
@reloxx13
Copy link
Contributor Author

Heya, i would like to add, that style="width... does also work.

in my line was a missing = , thats why i corrected it.

br
nils

@arendst
Copy link
Owner

arendst commented Dec 14, 2017

I know it worked but this way I gain some code bytes back...

@reloxx13
Copy link
Contributor Author

ahh okay, good to know thank you :)

@reloxx13 reloxx13 deleted the patch-1 branch December 14, 2017 18:16
arendst added a commit that referenced this pull request Jan 7, 2018
@arendst
v5.11.0
9c9a80f 
5.11.0 20180107
 * Minor webpage HTML optimizations (#1358)
 * Updated
German translation (#1438)
 * Change Sonoff Pow Energy MQTT data message
and consolidate Status 8 into Status 10
 * Change ADS1115 default
voltage range from +/-2V to +/-6V (#1289)
 * Change text to Active for 3
minutes (#1364)
 * Change Wemo SetBinaryState to distinguish from
GetBinaryState (#1357)
 * Change output of HTTP command to valid JSON
and Array only (#1363)
 * Removed all MQTT, JSON and Command language
defines from locale files and set fixed to English (#1473)
 * Renamed
commands Color2,3,4 to Color3,4,5
 * Fix BME280 calculation (#1051)
 *
Fix Sonoff Bridge missed learned key if learned data contains 0x55 (End
of Transmission) flag (#1095, #1294)
 * Fix PWM initialization in
Dimmer/Color mode (#1321)
 * Fix Wemo Emulation (#1357)
 * Fix display
of build date and time in non-english locale (#1465)
 * Fix Wemo and Hue
emulation by adding M-Search response delay (#1486)
 * Add libraries
Adafruit_BME680-1.0.5, Adafruit_Sensor-1.0.2.02, TasmotaSerial-1.0.0 and
TSL2561-Arduino-Library
 * Add command Color2 to set color while keeping
same dimmer value
 * Add device function pointers
 * Add support for
SenseAir S8 CO2 sensor
 * Add color led signal to Carbon Dioxide (CO2)
sensors using defines CO2_LOW and CO2_HIGH in user_config.h
 * Add
support for Domoticz Air Quality sensor to be used by MH-Z19(B) and
SenseAir sensors
 * Add support for PZEM004T energy sensor
 * Add
support for iTead SI7021 temperature and humidity sensor by
consolidating DHT22 into AM2301 and using former DHT22 as SI7021 (#735)

* Add support for BME680 using adafruit libraries (#1212)
 * Add support
for MH-Z19(B) CO2 sensor (#561, #1248)
 * Add multipress support and
more user configurable GPIO to Sonoff Dual R2 (#1291)
 * Add support for
TSL2561 using adafruit library (#661, #1311)
 * Add support for SHT3x
(#1314)
 * Add support for Arilux LC06 (#1414)
 * Add Italian language
file (#1449)
 * Add 2nd Gen Alexa support to Wemo emulation discovery
(#1357, #1450)
 * Add define for additional number of WS2812 schemes
(#1463)
joecotton pushed a commit to joecotton/Sonoff-Tasmota that referenced this pull request Jan 8, 2018
@arendst @joecotton
v5.11.0
6de4618 
5.11.0 20180107
 * Minor webpage HTML optimizations (arendst#1358)
 * Updated
German translation (arendst#1438)
 * Change Sonoff Pow Energy MQTT data message
and consolidate Status 8 into Status 10
 * Change ADS1115 default
voltage range from +/-2V to +/-6V (arendst#1289)
 * Change text to Active for 3
minutes (arendst#1364)
 * Change Wemo SetBinaryState to distinguish from
GetBinaryState (arendst#1357)
 * Change output of HTTP command to valid JSON
and Array only (arendst#1363)
 * Removed all MQTT, JSON and Command language
defines from locale files and set fixed to English (arendst#1473)
 * Renamed
commands Color2,3,4 to Color3,4,5
 * Fix BME280 calculation (arendst#1051)
 *
Fix Sonoff Bridge missed learned key if learned data contains 0x55 (End
of Transmission) flag (arendst#1095, arendst#1294)
 * Fix PWM initialization in
Dimmer/Color mode (arendst#1321)
 * Fix Wemo Emulation (arendst#1357)
 * Fix display
of build date and time in non-english locale (arendst#1465)
 * Fix Wemo and Hue
emulation by adding M-Search response delay (arendst#1486)
 * Add libraries
Adafruit_BME680-1.0.5, Adafruit_Sensor-1.0.2.02, TasmotaSerial-1.0.0 and
TSL2561-Arduino-Library
 * Add command Color2 to set color while keeping
same dimmer value
 * Add device function pointers
 * Add support for
SenseAir S8 CO2 sensor
 * Add color led signal to Carbon Dioxide (CO2)
sensors using defines CO2_LOW and CO2_HIGH in user_config.h
 * Add
support for Domoticz Air Quality sensor to be used by MH-Z19(B) and
SenseAir sensors
 * Add support for PZEM004T energy sensor
 * Add
support for iTead SI7021 temperature and humidity sensor by
consolidating DHT22 into AM2301 and using former DHT22 as SI7021 (arendst#735)

* Add support for BME680 using adafruit libraries (arendst#1212)
 * Add support
for MH-Z19(B) CO2 sensor (arendst#561, arendst#1248)
 * Add multipress support and
more user configurable GPIO to Sonoff Dual R2 (arendst#1291)
 * Add support for
TSL2561 using adafruit library (arendst#661, arendst#1311)
 * Add support for SHT3x
(arendst#1314)
 * Add support for Arilux LC06 (arendst#1414)
 * Add Italian language
file (arendst#1449)
 * Add 2nd Gen Alexa support to Wemo emulation discovery
(arendst#1357, arendst#1450)
 * Add define for additional number of WS2812 schemes
(arendst#1463)
@drbeat
Copy link

drbeat commented Jan 17, 2018

width attribute on table is deprecated in html5
so best practice would be
style="width:100%"

@arendst
Copy link
Owner

arendst commented Jan 17, 2018

Thought so... Will revert the width change in next pre-release.

arendst added a commit that referenced this pull request Jan 18, 2018
@arendst
v5.11.1c - Fixes and experimental Hass Discovery
1538d30 
5.11.1c
 * Make command color parameter input less strict to ease Hass
support
 * Add ColorTemperature to light status message
 * Change
PubSubClient.h define MQTT_MAX_PACKET_SIZE from 512 to 1000 for Hass
support
 * Make define MESSZ dependent on PubSubClient.h define
MQTT_MAX_PACKET_SIZE
 * Fix logging line length around 400 characters
 *
Change module name Wemos D1 mini into Generic (#1220)
 * Revert HTML
change from width=100% to style=width:100% supporting HTML5 (#1358)
 *
Add experimental (still Hass python exceptions) Home Assistant Discovery
for switch and light to be enabled by command SetOption19 1 (#1534)
 *
Updated French Translation (#1561)
 * Fix DS18B20 temperature JSON
decimal dot (#1561)
 * Add Spanish language file (#1589)
 * Update
Italian Language file (#1594)
 * Consolidate WIFI_MANAGER_SEC into
WIFI_CONFIG_SEC (#1616)
 * Fix Energy JSON message (#1621)
@reloxx13
Copy link
Contributor Author

hey,

u missed the unit here:

grafik

@arendst
Copy link
Owner

arendst commented Jan 21, 2018

I thought it would default to px but after reading this https://stackoverflow.com/questions/11274904/fallback-for-css-attributes-without-unit you're right so I'll add px to it.

To my surprise it indeed makes a difference and it looks like I envisioned so thanx for the comment!

@reloxx13
Copy link
Contributor Author

reloxx13 commented Jan 21, 2018 •
edited
Loading

you also have everything as % and not as px, i dont know why you made px here instead of 60% and 40% Oo

grafik

@arendst
Copy link
Owner

arendst commented Jan 21, 2018

It's px because I want the input field of fixed length. Currently looking at the domoticz part as there it is still wrong too. Might change to % sometime...

arendst added a commit that referenced this pull request Feb 9, 2018
@arendst
v5.12.0
600c4b1 
5.12.0 20180209
* Change library PubSubClient.h define MQTT_MAX_PACKET_SIZE from 512 to
1000 for Home Assistant  support
* Change relation of define MESSZ being dependent on PubSubClient.h
define MQTT_MAX_PACKET_SIZE
* Change command color parameter input checks to less strict for Home
Assistant support
* Change command Ina219Mode into command Sensor13
* Change commands HlwPCal, HlwUCal and HlwICal to PowerCal, VoltageCal
and CurrentCal to be used for both Pow and S31 calibration
* Change commands HlwPSet, HlwUSet and HlwISet to PowerSet, VoltageSet
and CurrentSet to be used for both Pow and S31 calibration
* Change uptime from hour to second resulting in a display of
123T13:45:21 where 123 is days
* Change module name Wemos D1 mini into Generic (#1220)
* Change HTML from width=100% to style=width:100% supporting HTML5
(#1358)
* Change OSWATCH_RESET_TIME (Blocked loop) from 30 to 120 seconds to
allow slow networks (#1556)
* Change WIFI_MANAGER_SEC into WIFI_CONFIG_SEC (#1616)
* Change function pointers code to save code space and memory (#1683)
* Change webserver argument processing gaining 5k code space (#1705)
* Change weblog memory usage (#1730, #1793, #1819)
* Update TasmotaSerial library to 1.1.0
* Update language files Italian (#1594), Dutch (#1723) and Spanish
(#1722)
* Fix Non-English JSON temperature unit attachement
* Fix Arilux RF induced exception by moving interrupt handler to iram on
non ESP8266/Arduino lib v2.3.0
* Fix truncated command names and wrong response for DomoticzSwitchIdx
(#1571)
* Fix %-sign issue as printf escape character in Humidity and Sonoff SC
(#1579)
* Fix DS18B20 temperature JSON decimal dot (#1561)
* Fix Energy JSON message (#1621)
* Fix IRSend parameter translation (#1636)
* Fix TSL2561 device detection (#1644, #1825)
* Fix BME680 teleperiod resistance measuring (#1647)
* Fix Energy Monitoring Energy Today and Energy Total reading after
restart (#1648)
* Fix IRReceive Data value (#1663)
* Fix Energy Monitoring Energy Period roll-over (#1688)
* Fix compiler warnings (#1774)
* Fix command PWM response if no PWM channel is configured (#1783)
* Add locale Decimal Separator to Web sensor page
* Add ColorTemperature to light status message
* Add command PowerOnState option 5 which inverts PulseTime and allows
for delayed always on after power on
* Add OtaMagic two step Web server OTA upgrade using filename-minimal
image if OTA free space is too small
* Add support for PMS5003 and PMS7003 particle concentration sensor
* Add command SetOption21 1 to allow Energy Monitoring when power is off
on Sonoff Pow and Sonoff S31 (#1420)
* Add Chinese language file (#1551)
* Add French language file (#1561)
* Add Spanish language file (#1589)
* Add HTTP Allow Cross Origin removed from ESP8266/Arduino lib v2.4.0
(#1572)
* Add Home Assistant MQTT Discovery for switch and light to be enabled
by command SetOption19 1 (#1534) or define
HOME_ASSISTANT_DISCOVERY_ENABLE in user_config.h (#1685)
* Add command State to retrieve device state information (same data as
teleperiod state and status 11 in slightly different JSON format)
* Add optional login to Webserver AP mode (#1587, #1635)
* Add command Sensor15 2 to start MHZ19(B) Zero Point Calibration
(#1643)
* Add support for Sonoff S31 Smart Socket with Power Consumption
Detection (#1626)
* Add command SetOption20 to allow update of Dimmer/Color/Ct without
turning power on (#1719, #1741)
* Add NTP sync time slot based on chip id (#1773)
* Add cursor pointer to web button (#1836)
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 6, 2018
@arendst
Fix BME680 Pressure and minor HTNL optimizations
5bcca17 
* Fix BME680 pressure data (arendst#1356)
 * Minor webpage HTML optimizations
(arendst#1358)
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 6, 2018
@arendst
v5.11.1c - Fixes and experimental Hass Discovery
4b36e60 
5.11.1c
 * Make command color parameter input less strict to ease Hass
support
 * Add ColorTemperature to light status message
 * Change
PubSubClient.h define MQTT_MAX_PACKET_SIZE from 512 to 1000 for Hass
support
 * Make define MESSZ dependent on PubSubClient.h define
MQTT_MAX_PACKET_SIZE
 * Fix logging line length around 400 characters
 *
Change module name Wemos D1 mini into Generic (arendst#1220)
 * Revert HTML
change from width=100% to style=width:100% supporting HTML5 (arendst#1358)
 *
Add experimental (still Hass python exceptions) Home Assistant Discovery
for switch and light to be enabled by command SetOption19 1 (arendst#1534)
 *
Updated French Translation (arendst#1561)
 * Fix DS18B20 temperature JSON
decimal dot (arendst#1561)
 * Add Spanish language file (arendst#1589)
 * Update
Italian Language file (arendst#1594)
 * Consolidate WIFI_MANAGER_SEC into
WIFI_CONFIG_SEC (arendst#1616)
 * Fix Energy JSON message (arendst#1621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reloxx13 @arendst @drbeat