Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine tune menu record card #2224

Closed
Amelie-V opened this issue Jan 18, 2023 · 0 comments · Fixed by #2240 or #2304
Closed

Fine tune menu record card #2224

Amelie-V opened this issue Jan 18, 2023 · 0 comments · Fixed by #2240 or #2304
Assignees
@leiyre
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Milestone
v1.3.0

Comments

@Amelie-V
Copy link
Member

Amelie-V commented Jan 18, 2023 •
edited by frascuchon

Is your feature request related to a problem? Please describe.
We need to polish this menu after adding the find similar features.

Describe the solution you'd like
A clear and concise description of what you want to happen.
About the icon menu:
https://uxplanet.org/choose-correct-menu-icon-for-your-navigation-7ffc22df80ac

  • Change kebab for meatball
  • Add hover effect on all elements (include meatball)
  • Add a tooltip to the date "Creation date"
  • Apply a equal space in px between each component (icon bt, text bt, text in)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@Amelie-V Amelie-V added the type: enhancement Indicates new feature requests label Jan 18, 2023
@Amelie-V Amelie-V added this to the v1.3.0 milestone Jan 18, 2023
@Amelie-V Amelie-V added area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior type: documentation Improvements or additions to documentation Cloud labels Jan 23, 2023
@leiyre leiyre removed the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Jan 23, 2023
@Amelie-V Amelie-V added area: ui Indicates that an issue or pull request is related to the User Interface (UI) and removed type: bug Indicates an unexpected problem or unintended behavior type: documentation Improvements or additions to documentation Cloud area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Jan 23, 2023
@leiyre leiyre mentioned this issue Jan 24, 2023
Merged
5 tasks
leiyre added a commit that referenced this issue Jan 25, 2023
@leiyre
style: Fine tune menu record card (#2240)
62148e5 
# Description

Include tooltip for event timestamp
Include hover status for menu
Same space between items in record right area
Update tooltip position and size

Closes #2224

**Type of change**

Please delete options that are not relevant.

- [x] Update styles

**Checklist**

- [x] I have merged the original branch into my forked branch
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] My changes generate no new warnings
@frascuchon frascuchon mentioned this issue Feb 7, 2023
Merged
frascuchon added a commit that referenced this issue Feb 9, 2023
@frascuchon
chore: prepare release v1.3.0 (#2304)
de0983f 
# Changelog

All notable changes to this project will be documented in this file. See
[standard-version](https://github.com/conventional-changelog/standard-version)
for commit guidelines.

## [1.3.0](v1.2.1...v1.3.0)
(2023-02-09)


### Features

* better log error handling
([#2245](#2245))
([66e5cce](66e5cce)),
closes [#2005](#2005)
* Change view mode order in sidebar
([#2215](#2215))
([dff1ea1](dff1ea1)),
closes [#2214](#2214)
* **Client:** Expose keywords dataset metrics
([#2290](#2290))
([a945c5e](a945c5e)),
closes [#2135](#2135)
* **Client:** relax client constraints for rules management
([#2242](#2242))
([6e749b7](6e749b7)),
closes [#2048](#2048)
* Create a multiple contextual help component
([#2255](#2255))
([a35fae2](a35fae2)),
closes [#1926](#1926)
* Include record event_timestamp
([#2156](#2156))
([3992b8f](3992b8f)),
closes [#1911](#1911)
* updated the `prepare_for_training` methods
([#2225](#2225))
([e53c201](e53c201)),
closes [#2154](#2154)
[#2132](#2132)
[#2122](#2122)
[#2045](#2045)
[#1697](#1697)


### Bug Fixes

* **Client:** formatting caused offset in prediction
([#2241](#2241))
([d65db5a](d65db5a))
* **Client:** Log remaining data when shutdown the dataset consumer
([#2269](#2269))
([d78963e](d78963e)),
closes [#2189](#2189)
* validate predictions fails on text2text
([#2271](#2271))
([f68856e](f68856e)),
closes [#2252](#2252)


### Visual enhancements

* Fine tune menu record card
([#2240](#2240))
([62148e5](62148e5)),
closes [#2224](#2224)
* Rely on box-shadow to provide the secondary underline
([#2283](#2283))
([d786171](d786171)),
closes [#2282](#2282)
[#2282](#2282)


### Documentation

* Add deploy on Spaces buttons
([#2293](#2293))
([60164a0](60164a0))
* fix typo in documentation
([#2296](#2296))
([ab8e85e](ab8e85e))
* Improve deployment and quickstart docs and tutorials
([#2201](#2201))
([075bf94](075bf94)),
closes [#2162](#2162)
* More spaces! ([#2309](#2309))
([f02eb60](f02eb60))
* Remove cut-off sentence in docs codeblock
([#2287](#2287))
([7e87f20](7e87f20))
* Rephrase `to know more` into `to learn more` in Quickstart login page
([#2305](#2305))
([6082a26](6082a26))
* Replace leftover `rubrix.apikey` with `argilla.apikey`
([#2286](#2286))
([4871127](4871127)),
closes [#2254](#2254)
[#2254](#2254)
* Simplify token attributions code block
([#2322](#2322))
([4cb6ae1](4cb6ae1))
* Tutorial buttons
([#2310](#2310))
([d6e02de](d6e02de))
* Update colab guide
([#2320](#2320))
([e48a7cc](e48a7cc))
* Update HF Spaces creation image
([#2314](#2314))
([e4b2a04](e4b2a04))


## As always, thanks to our amazing contributors!


- add repr method for Rule, Dataset. (#2148) by @Ankush-Chander
- opensearch docker compose file doesn't run (#2228) by @kayvane1
- Docs: fix typo in documentation (#2296) by @anakin87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.3.0
2 participants
@leiyre @Amelie-V