Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better log error handling #2245

Merged
merged 8 commits into from Jan 30, 2023
Merged

feat: better log error handling #2245

merged 8 commits into from Jan 30, 2023

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jan 24, 2023 •
edited

Description

This PR adds code to better error parsing for bulk index errors, and other HTTP errors in general:

  • For bulk errors, return the reason and the causes of the errors for each failed record in the bulk.
  • Reduce args info when an error is raised from a rg.log
  • Parse HTTP status codes and responses other than those defined by the Argilla server.

Closes #2005

Type of change

Please delete options that are not relevant.

  • Improvement

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I added comments to my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited

Codecov Report

Base: 94.33% // Head: 93.95% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (78b41d4) compared to base (b5f84dc).
Patch coverage: 90.24% of modified lines in pull request are covered.

❗ Current head 78b41d4 differs from pull request most recent head b361b2e. Consider uploading reports for the commit b361b2e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2245      +/-   ##
===========================================
- Coverage    94.33%   93.95%   -0.39%     
===========================================
  Files          153      161       +8     
  Lines         7381     7743     +362     
===========================================
+ Hits          6963     7275     +312     
- Misses         418      468      +50
Flag Coverage Δ
pytest 93.95% <90.24%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argilla/__init__.py 100.00% <ø> (ø)
...la/server/apis/v0/handlers/token_classification.py 100.00% <ø> (ø)
...rc/argilla/server/daos/backend/mappings/helpers.py 97.22% <ø> (-1.47%) ⬇️
src/argilla/server/routes.py 100.00% <ø> (ø)
src/argilla/server/services/metrics/service.py 100.00% <ø> (ø)
src/argilla/server/helpers.py 80.32% <38.88%> (-17.35%) ⬇️
...rgilla/server/daos/backend/client_adapters/base.py 69.56% <69.56%> (ø)
src/argilla/server/server.py 84.26% <71.42%> (+1.66%) ⬆️
src/argilla/client/sdk/_helpers.py 83.33% <75.00%> (-16.67%) ⬇️
src/argilla/client/sdk/commons/errors_handler.py 87.09% <75.00%> (+0.88%) ⬆️
... and 86 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

davidberenstein1957
davidberenstein1957 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM besides some fine-tuning handled here.

@davidberenstein1957 davidberenstein1957 merged commit 66e5cce into develop Jan 30, 2023
@davidberenstein1957 davidberenstein1957 deleted the feature/better-log-error-handling branch January 30, 2023 17:08
@frascuchon frascuchon mentioned this pull request Feb 7, 2023
Merged
frascuchon added a commit that referenced this pull request Feb 9, 2023
@frascuchon
chore: prepare release v1.3.0 (#2304)
de0983f 
# Changelog

All notable changes to this project will be documented in this file. See
[standard-version](https://github.com/conventional-changelog/standard-version)
for commit guidelines.

## [1.3.0](v1.2.1...v1.3.0)
(2023-02-09)


### Features

* better log error handling
([#2245](#2245))
([66e5cce](66e5cce)),
closes [#2005](#2005)
* Change view mode order in sidebar
([#2215](#2215))
([dff1ea1](dff1ea1)),
closes [#2214](#2214)
* **Client:** Expose keywords dataset metrics
([#2290](#2290))
([a945c5e](a945c5e)),
closes [#2135](#2135)
* **Client:** relax client constraints for rules management
([#2242](#2242))
([6e749b7](6e749b7)),
closes [#2048](#2048)
* Create a multiple contextual help component
([#2255](#2255))
([a35fae2](a35fae2)),
closes [#1926](#1926)
* Include record event_timestamp
([#2156](#2156))
([3992b8f](3992b8f)),
closes [#1911](#1911)
* updated the `prepare_for_training` methods
([#2225](#2225))
([e53c201](e53c201)),
closes [#2154](#2154)
[#2132](#2132)
[#2122](#2122)
[#2045](#2045)
[#1697](#1697)


### Bug Fixes

* **Client:** formatting caused offset in prediction
([#2241](#2241))
([d65db5a](d65db5a))
* **Client:** Log remaining data when shutdown the dataset consumer
([#2269](#2269))
([d78963e](d78963e)),
closes [#2189](#2189)
* validate predictions fails on text2text
([#2271](#2271))
([f68856e](f68856e)),
closes [#2252](#2252)


### Visual enhancements

* Fine tune menu record card
([#2240](#2240))
([62148e5](62148e5)),
closes [#2224](#2224)
* Rely on box-shadow to provide the secondary underline
([#2283](#2283))
([d786171](d786171)),
closes [#2282](#2282)
[#2282](#2282)


### Documentation

* Add deploy on Spaces buttons
([#2293](#2293))
([60164a0](60164a0))
* fix typo in documentation
([#2296](#2296))
([ab8e85e](ab8e85e))
* Improve deployment and quickstart docs and tutorials
([#2201](#2201))
([075bf94](075bf94)),
closes [#2162](#2162)
* More spaces! ([#2309](#2309))
([f02eb60](f02eb60))
* Remove cut-off sentence in docs codeblock
([#2287](#2287))
([7e87f20](7e87f20))
* Rephrase `to know more` into `to learn more` in Quickstart login page
([#2305](#2305))
([6082a26](6082a26))
* Replace leftover `rubrix.apikey` with `argilla.apikey`
([#2286](#2286))
([4871127](4871127)),
closes [#2254](#2254)
[#2254](#2254)
* Simplify token attributions code block
([#2322](#2322))
([4cb6ae1](4cb6ae1))
* Tutorial buttons
([#2310](#2310))
([d6e02de](d6e02de))
* Update colab guide
([#2320](#2320))
([e48a7cc](e48a7cc))
* Update HF Spaces creation image
([#2314](#2314))
([e4b2a04](e4b2a04))


## As always, thanks to our amazing contributors!


- add repr method for Rule, Dataset. (#2148) by @Ankush-Chander
- opensearch docker compose file doesn't run (#2228) by @kayvane1
- Docs: fix typo in documentation (#2296) by @anakin87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

too verbose failure logging during failed rg.log() (with too large chunk_size)
2 participants
@frascuchon @davidberenstein1957