feat(Client): relax client constraints for rules management #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When adding a new rule, just warn and ignore if already created - When update a rule, create it is not already created
Codecov ReportBase: 94.33% // Head: 93.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2242 +/- ##
===========================================
- Coverage 94.33% 93.98% -0.36%
===========================================
Files 153 161 +8
Lines 7381 7714 +333
===========================================
+ Hits 6963 7250 +287
- Misses 418 464 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Hi @frascuchon It looks fine besides some comments w.r.t. the code and a general comment about missing error handling for delete_dataset_labeling_rules, fetch_dataset_labeling_rules and rule_metrics_for_dataset. All these should have some NotFound error too IMO.
davidberenstein1957
approved these changes
Feb 6, 2023
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
frascuchon
added a commit
that referenced
this pull request
Feb 9, 2023
# Changelog All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. ## [1.3.0](v1.2.1...v1.3.0) (2023-02-09) ### Features * better log error handling ([#2245](#2245)) ([66e5cce](66e5cce)), closes [#2005](#2005) * Change view mode order in sidebar ([#2215](#2215)) ([dff1ea1](dff1ea1)), closes [#2214](#2214) * **Client:** Expose keywords dataset metrics ([#2290](#2290)) ([a945c5e](a945c5e)), closes [#2135](#2135) * **Client:** relax client constraints for rules management ([#2242](#2242)) ([6e749b7](6e749b7)), closes [#2048](#2048) * Create a multiple contextual help component ([#2255](#2255)) ([a35fae2](a35fae2)), closes [#1926](#1926) * Include record event_timestamp ([#2156](#2156)) ([3992b8f](3992b8f)), closes [#1911](#1911) * updated the `prepare_for_training` methods ([#2225](#2225)) ([e53c201](e53c201)), closes [#2154](#2154) [#2132](#2132) [#2122](#2122) [#2045](#2045) [#1697](#1697) ### Bug Fixes * **Client:** formatting caused offset in prediction ([#2241](#2241)) ([d65db5a](d65db5a)) * **Client:** Log remaining data when shutdown the dataset consumer ([#2269](#2269)) ([d78963e](d78963e)), closes [#2189](#2189) * validate predictions fails on text2text ([#2271](#2271)) ([f68856e](f68856e)), closes [#2252](#2252) ### Visual enhancements * Fine tune menu record card ([#2240](#2240)) ([62148e5](62148e5)), closes [#2224](#2224) * Rely on box-shadow to provide the secondary underline ([#2283](#2283)) ([d786171](d786171)), closes [#2282](#2282) [#2282](#2282) ### Documentation * Add deploy on Spaces buttons ([#2293](#2293)) ([60164a0](60164a0)) * fix typo in documentation ([#2296](#2296)) ([ab8e85e](ab8e85e)) * Improve deployment and quickstart docs and tutorials ([#2201](#2201)) ([075bf94](075bf94)), closes [#2162](#2162) * More spaces! ([#2309](#2309)) ([f02eb60](f02eb60)) * Remove cut-off sentence in docs codeblock ([#2287](#2287)) ([7e87f20](7e87f20)) * Rephrase `to know more` into `to learn more` in Quickstart login page ([#2305](#2305)) ([6082a26](6082a26)) * Replace leftover `rubrix.apikey` with `argilla.apikey` ([#2286](#2286)) ([4871127](4871127)), closes [#2254](#2254) [#2254](#2254) * Simplify token attributions code block ([#2322](#2322)) ([4cb6ae1](4cb6ae1)) * Tutorial buttons ([#2310](#2310)) ([d6e02de](d6e02de)) * Update colab guide ([#2320](#2320)) ([e48a7cc](e48a7cc)) * Update HF Spaces creation image ([#2314](#2314)) ([e4b2a04](e4b2a04)) ## As always, thanks to our amazing contributors! - add repr method for Rule, Dataset. (#2148) by @Ankush-Chander - opensearch docker compose file doesn't run (#2228) by @kayvane1 - Docs: fix typo in documentation (#2296) by @anakin87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2048
Type of change
Please delete options that are not relevant.
Checklist