-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status progressing when status.loadbalancer.ingress is non empty and does not have Hostname OR IP #997
Comments
ingress not update it. if u use traefik and version above 1.7, it has config. |
@peterbosalliandercom - which ingress controller are you running? Do you mind also providing the ingress object YAML? So far I know of the following ingress controllers which have issues with setting status. I would like to understand the logic & behavior of other problematic controllers as well.
If your controller cannot be configured in a way that it updates apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: test-ingress
spec:
rules:
- http:
paths:
- path: /testpath
backend:
serviceName: test
servicePort: 80
status:
loadBalancer:
ingress:
- hostname: placeholder The other point is that we will be implementing #911 (comment) which will allow users the ability to override our built-in health assessments, including the ingress health assessment. BTW, the Ingress health assessment logic is in-line with what is being proposed with sig-apps: kubernetes-sigs/application#78 |
Hereby an example ingress object Yaml file:
|
Later edit: Please disregard this, it seems we have a problem with the kong ingress controller, it wasn't deployed correctly The same thing happens for kong ingress
|
BTW, the Ingress health assessment logic is in-line with what is being proposed with sig-apps: kubernetes-sigs/application#78 According to above it should be non empty and thats exactly what it is. The list is non empty. Shouldn't it be correct that way? |
I think you're right. I think we may have interpreted this incorrectly. I think the correct behavior should be: Progressing:
Healthy:
|
Thank you for the reponse. |
Was kubernetes-sigs/application#78 approved ? It would be nice to have the status "not continously progressing " when not using "load-balancers" it seems "load-balancers" in the concept of k8s (which are always assumed to come from cloud-provider) and ingress are slightly different concepts, and that one is possible without the other. |
If your service type load balancer never gets an ip, you can write a custom
ingress health check that always returns Healthy
…On Mon, Sep 2, 2019 at 4:12 AM Bertrand Nouvel ***@***.***> wrote:
Was kubernetes-sigs/application#78
<kubernetes-sigs/application#78> approved ? It
would be nice to have the status "not continously progressing " when not
using "load-balancers" it seems "load-balancers" in the concept of k8s
(which are always assumed to come from cloud-provider) and ingress are
slightly different concepts, and that one is possible without the other.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#997?email_source=notifications&email_token=ADAW76LQB6NZ2MSP2CTI7HLQHTYJRA5CNFSM4GO324ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5VQVEQ#issuecomment-527108754>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADAW76L7DXE3JPI2TY5XXLDQHTYJRANCNFSM4GO324ZA>
.
|
@lcostea I also have this issue with the Kong ingress controller. Do you happen to remember what was not deployed correctly? |
@jessesuen - I wrote below to exlude my service, but its not working :/
|
…oller argoproj/argo-cd#997 Signed-off-by: bukowa <gitbukowa@gmail.com>
…nx controller argoproj/argo-cd#997" This reverts commit 126a498. Signed-off-by: bukowa <gitbukowa@gmail.com>
Was running into the same things, but your path for the service is incorrect. As described in the docs, you need to use Service:
health.lua: |
hs = {}
hs.status = "Healthy"
return hs
|
Similarly, the ingress for grafana is likely empty for status.loadBalancer.ingress, so we consider this not healthy.
See:
https://github.com/argoproj/argo-cd/blob/master/docs/health.md
In our situation this status.loadBalancer.ingress is
status:
loadBalancer:
ingress:
- {}
For us this is a valid state, we do not have a hostname or IP in that field maybe thats the reason?
We do not use a loadbalancer so it is empty. I think this problem needs to be fixed right?
The text was updated successfully, but these errors were encountered: