Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code-block #9874

Closed
wants to merge 1 commit into from
Closed

Conversation

IndraGunawan
Copy link

@IndraGunawan IndraGunawan commented Jul 5, 2022

Signed-off-by: Indra Gunawan indra@propertyguru.com.sg

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/services/slack/
before
Screenshot

after
Screenshot

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #9874 (fa18344) into master (c1d8173) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9874      +/-   ##
==========================================
- Coverage   45.86%   45.73%   -0.14%     
==========================================
  Files         227      227              
  Lines       26864    26953      +89     
==========================================
+ Hits        12322    12327       +5     
- Misses      12862    12946      +84     
  Partials     1680     1680              
Impacted Files Coverage Δ
cmd/argocd-k8s-auth/commands/aws.go 17.64% <0.00%> (-0.36%) ⬇️
cmd/argocd/commands/admin/settings_rbac.go 23.80% <0.00%> (-0.26%) ⬇️
cmd/argocd/commands/admin/project.go 27.97% <0.00%> (-0.20%) ⬇️
cmd/argocd/commands/cluster.go 8.97% <0.00%> (-0.20%) ⬇️
cmd/argocd/commands/app.go 20.00% <0.00%> (-0.15%) ⬇️
cmd/argocd/commands/admin/app.go 30.37% <0.00%> (-0.13%) ⬇️
cmd/argocd/commands/app_resources.go 8.47% <0.00%> (-0.08%) ⬇️
cmd/argocd/commands/gpg.go 0.00% <0.00%> (ø)
cmd/argocd/commands/cert.go 0.00% <0.00%> (ø)
cmd/argocd/commands/repo.go 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d8173...fa18344. Read the comment docs.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Indra Gunawan <indra@propertyguru.com.sg>
@crenshaw-dev
Copy link
Member

Closing for now to wait for the upstream change.

@omBratteng
Copy link
Contributor

The source of those docs comes from https://github.com/argoproj/notifications-engine, and I have a PR open to fix the remaining codefence argoproj/notifications-engine#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants