Added support for S3 access logs #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arithmetric
reviewed
Aug 6, 2019
| } | ||
| item.time = item.time.replace(/:/, ' ').replace(/\[/, ''); | ||
| item.zone = item.zone.replace(/\]/, ''); | ||
| item[config.dateField] = new Date(item.time + item.zone); |
There was a problem hiding this comment.
I'd recommend using new Date(...).toISOString() to explicitly set this field as an ISO-formatted date string. This is what is implicitly done through the JSON stringify later.
See the pattern from: https://github.com/arithmetric/lambda-stash/blob/master/handlers/formatCloudwatchLogs.js#L54
|
This is great, thanks @drummerjoe. I will merge this PR, and then I plan to make two changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new format handler for support of AWS S3 access logs. Based on the ELBv2 handler which only required modifications to the field list and a bit of formatting of the date to match ISO-8601.
Fixes #25