Skip to content

Added support for S3 access logs #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Added support for S3 access logs #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3d767e
Added support for S3 access logs
Aug 2, 2019
85f09a2
Fixed ESLint errors
Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions handlers/formatS3access.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
exports.process = function(config) {
console.log('formatS3access for S3 hosted application logs');
if (!config.data ||
(!config.data.length && config.data.length !== 0)) {
return Promise.reject('Received unexpected S3 log format:' +
JSON.stringify(config.data));
}

var output = [];
var fields = [
'bucket_owner',
'bucket',
'time',
'zone',
'remote_ip',
'requester',
'request_id',
'operation',
'key',
'request_uri',
'http_status',
'error_code',
'bytes_sent',
'object_size',
'total_time',
'turn_around_time',
'referrer',
'user_agent',
'version_id',
'host_id',
'signature_version',
'cipher_suite',
'authentication_type',
'host_header',
'tls_version'
];
var numRows = config.data.length;
var numCols;
var i;
var j;
var row;
var item;

for (i = 0; i < numRows; i++) {
row = config.data[i];
if (row.length !== 25) {
console.log('Expected 25 columns in row. Found ' + row.length + ': ' +
config.data[i]);
}

item = {};
numCols = Math.min(row.length, fields.length);
for (j = 0; j < numCols; j++) {
item[fields[j]] = row[j];
}
item.time = item.time.replace(/:/, ' ').replace(/\[/, '');
item.zone = item.zone.replace(/\]/, '');
item[config.dateField] = new Date(item.time + item.zone);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using new Date(...).toISOString() to explicitly set this field as an ISO-formatted date string. This is what is implicitly done through the JSON stringify later.

See the pattern from: https://github.com/arithmetric/lambda-stash/blob/master/handlers/formatCloudwatchLogs.js#L54

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch.

output.push(item);
}
config.data = output;
return Promise.resolve(config);
};