Problems with adding extra images in Manage Solutions Dialog

[jreineckearm]

Type: Bug Report

Describe the bug

• OS and Version: Windows 11 Enterprise 24H2
• VS Code Version: 1.105.0
• Extension Version: Internal build 1.60.1-82-gc02d8b1
• Target Device: Alif AE722F80F55D5LS
• Other extensions you installed (and if the issue persists after disabling them):
• A clear and concise description of what the bug is.

A couple of issues found when using a dev drop of the Manage Solutions Dialog:

• Manage Solutions Dialog locks up when I add another AXF file. Can one that is already added by context because they are treated differently. You can recover by closing and reopening the dialog. The entry is then added in GUI (Save button however disabled).
• Once an extra image is successfully added by GUI to the csolution target-set, I see warnings in the status bar. These come from backslashes being added on Windows which seem to be disallowed by a schema.
• I can add the same extra image twice to the GUI and Save. When I clock unlink on one of the entries in GUI, both are lost. Strictly speaking, this is OK. But it may appear a bit confusing that you were able to add the exact duplicate in the GUI in the first place.
• How can I specify the core/pname an extra image belongs to through GUI? Or is the intention that images without pname in a multi-core solution apply to all cores? Which would need change in the debug adapter templates which currently check for strict pname equality.
  Note that you can add the pname to an extra image by device property with the notation :<pname>.

To Reproduce
Steps to reproduce the behavior:

1. Use the MLEK_AV_DualCore example
2. Play through the above scenarios.

Expected behavior

1. View does not lock up
2. Created entries on Windows agree with schema

Code sample and logs

• Code sample
• tasks.json

Screenshots

Additional context

[arneschmid]

This is going to be fixed in PR https://github.com/Arm-Debug/vscode-cmsis-csolution/pull/2512

[jreineckearm]

I see only the first item addressed. What about the other three?

[jreineckearm]

Should have mentioned the build used for testing: arm.cmsis-csolution-1.60.1-95-g5c202bd