Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Darwin 23 setup #193

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Add support for Darwin 23 setup #193

merged 5 commits into from
Apr 10, 2024

Conversation

Thistleman
Copy link
Contributor

This PR addresses several issues:

  • Update autoconf installed version to be compatible with brew installed automake
  • Update configure.ac file to add mysql dependent library paths for darwin systems automatically using brew
  • Add darwin_23 setup script due to forced migrations to Sonoma

@Thistleman
added d23 sonoma setup file
384ae16 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
@Thistleman
updated autoconf version 2.72 to support automake
36c01d9 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
@Thistleman
potential mysql link fix
9a04269 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
@Thistleman Thistleman requested a review from dchassin April 4, 2024 21:25
@dchassin dchassin changed the title Develop add d23 setup Add support for Darwin 23 setup Apr 4, 2024
dchassin
dchassin reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@dchassin dchassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • autoconf test is > 2.70 but error message is 2.72 or later

@Thistleman
fixed test >2.70
458ee93 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
@Thistleman
fixed autoconf test to >2.71
2baa807 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
@dchassin
Copy link
Member

dchassin commented Apr 5, 2024

Isn’t autoconf 2.72 only for Darwin 23? It looks like this applies to all versions.

@dchassin dchassin merged commit 22f6be4 into develop Apr 10, 2024
2 checks passed
@dchassin dchassin deleted the develop-add-d23-setup branch April 10, 2024 17:42
@dchassin dchassin mentioned this pull request Apr 10, 2024
Merged
10 tasks
dchassin pushed a commit to dchassin/gridlabd that referenced this pull request Apr 16, 2024
@Thistleman
Add support for Darwin 23 setup (arras-energy#193)
3262cbc 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
dchassin pushed a commit to dchassin/gridlabd that referenced this pull request Apr 16, 2024
@Thistleman
Add support for Darwin 23 setup (arras-energy#193)
c7e414a 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
dchassin pushed a commit to dchassin/gridlabd that referenced this pull request Apr 16, 2024
@Thistleman
Add support for Darwin 23 setup (arras-energy#193)
953e800 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
dchassin pushed a commit to dchassin/gridlabd that referenced this pull request Apr 17, 2024
@Thistleman
Add support for Darwin 23 setup (arras-energy#193)
76c123a 
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchassin dchassin dchassin left review comments

Assignees
No one assigned
Labels
None yet
Projects
Next patch update
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thistleman @dchassin