Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit tests #63

Closed
g4s8 opened this issue Apr 3, 2020 · 41 comments
Closed

More unit tests #63

g4s8 opened this issue Apr 3, 2020 · 41 comments

Comments

@g4s8
Copy link
Member

g4s8 commented Apr 3, 2020

Let's add more tests for Rpm metadata generators:

  • verify that it can update multiple files one by one
  • verify that the content is correct for all supported digests and NamingPolicy implementations
  • verify that it doesn't brake existing metadata in case of invalid package (e.g. generate metadata for first package, then try to generate for broken package)
@0crat
Copy link

0crat commented Apr 3, 2020

The job #63 assigned to @carlosmiranda/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@carlosmiranda
Copy link
Contributor

@0crat refuse

@0crat
Copy link

0crat commented Apr 3, 2020

@0crat refuse (here)

@carlosmiranda Job refused in 0 hours - no penalty, see §6

@0crat
Copy link

0crat commented Apr 3, 2020

The job #63 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@ammaratef45
Copy link
Contributor

@0crat refuse

@0crat
Copy link

0crat commented Apr 3, 2020

@0crat refuse (here)

@ammaratef45 The user @ammaratef45/z resigned from #63, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link

0crat commented Apr 3, 2020

@0crat refuse (here)

@ammaratef45 Job refused in 2 hours - no penalty, see §6

@0crat
Copy link

0crat commented Apr 3, 2020

The job #63 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@victornoel
Copy link
Contributor

@g4s8 Rpm metadata generator is the class Repomd?

@victornoel
Copy link
Contributor

@0crat wait for #67 to be merged

@g4s8
Copy link
Member Author

g4s8 commented Apr 3, 2020

@victornoel no, it's Rpm class. Repomd is responsible only for repomd.xml metadata file.

@0crat 0crat added the waiting label Apr 3, 2020
@victornoel
Copy link
Contributor

@g4s8 Repomd is used nowhere, and RepoUpdater seems to be solving the same problem, I don't get what Repomd is for then?

@g4s8
Copy link
Member Author

g4s8 commented Apr 3, 2020

@victornoel it looks like we forgot to delete Repomd class. It was replaced with RepoUpdater by the hotfix when we faced some critical performance issue with Xembly (it parses xml document fully in memory, but some documents in RPM repository may be huge enough). So actually, we need unit tests for Rpm class to be sure that it can generate metadata correctly, now we have too few asserts in tests about the metadata content.

@victornoel
Copy link
Contributor

@g4s8 well, I guess I did refactor Repomd yesterday and write a test for Repomd for nothing, I will leave this task for someone else then, I don't want to start again the whole process of wrapping my head around Rpm and existing RpmTest.

@0crat refuse

@0crat
Copy link

0crat commented Apr 3, 2020

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

@victornoel
Copy link
Contributor

@0crat refuse

@g4s8
Copy link
Member Author

g4s8 commented Apr 3, 2020

@victornoel ok, sorry, I forgot to refactor this module after the fix

@0crat
Copy link

0crat commented Apr 3, 2020

@0crat refuse (here)

@victornoel The user @victornoel/z resigned from #63, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link

0crat commented Apr 3, 2020

@0crat refuse (here)

@victornoel Job refused in 3 hours - no penalty, see §6

@0crat
Copy link

0crat commented Apr 24, 2020

The job #63 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@paulodamaso
Copy link
Contributor

@g4s8 RpmITCase is very confused and doesn't work. We need it working before thinking in improving it

@g4s8
Copy link
Member Author

g4s8 commented Apr 28, 2020

@g4s8 RpmITCase is very confused and doesn't work. We need it working before thinking in improving it

It's working now, see #153

@0crat
Copy link

0crat commented Apr 30, 2020

@paulodamaso/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@paulodamaso
Copy link
Contributor

@g4s8 I'm implementing the third case. How can add packages to the repository programatically so I can add a broken package to it?

paulodamaso referenced this issue in paulodamaso/artipie-rpm-adapter May 1, 2020
paulodamaso referenced this issue in paulodamaso/artipie-rpm-adapter May 1, 2020
@paulodamaso
Copy link
Contributor

@0crat wait for #158 review

@0crat 0crat added the waiting label May 1, 2020
paulodamaso referenced this issue in paulodamaso/artipie-rpm-adapter May 1, 2020
paulodamaso referenced this issue in paulodamaso/artipie-rpm-adapter May 12, 2020
paulodamaso referenced this issue in paulodamaso/artipie-rpm-adapter May 12, 2020
g4s8 added a commit that referenced this issue May 19, 2020
For #63: Added unit test to Rpm
@0pdd
Copy link

0pdd commented May 19, 2020

@g4s8 the puzzle #190 is still not solved.

@paulodamaso
Copy link
Contributor

@g4s8 merged, please close

@paulodamaso
Copy link
Contributor

@g4s8 ping

@g4s8
Copy link
Member Author

g4s8 commented May 25, 2020

@paulodamaso thanks

@g4s8 g4s8 closed this as completed May 25, 2020
@0crat
Copy link

0crat commented May 25, 2020

Job gh:artipie/rpm-adapter#63 is not assigned, can't get performer

@g4s8
Copy link
Member Author

g4s8 commented May 25, 2020

@0crat out

@0crat
Copy link

0crat commented May 25, 2020

@0crat out (here)

@g4s8 Job gh:artipie/rpm-adapter#63 is not assigned, can't get performer

@g4s8
Copy link
Member Author

g4s8 commented May 25, 2020

@0crat status

@0crat
Copy link

0crat commented May 25, 2020

@0crat status (here)

@g4s8 This is what I know about this job in CT2E6TK9B, as in §32:

  • The job #63 is not in scope
  • Job footprint (restricted area)

@g4s8
Copy link
Member Author

g4s8 commented May 25, 2020

@0crat pay 30min @paulodamaso

@0pdd
Copy link

0pdd commented Jun 2, 2020

@g4s8 the puzzle #218 is still not solved; solved: #190.

@0pdd
Copy link

0pdd commented Jun 4, 2020

@g4s8 all 2 puzzles are solved here: #190, #218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants