resolve #33

[Guseyn]

No description provided.

[g4s8]

@Guseyn please check few comments

[g4s8]

@Guseyn typo?

[Guseyn]

@g4s8 fixed.

[g4s8]

@Guseyn I don't agree with the design of this method and class - it has too many responsibilities: reading file sizes, calculating hash sums, reading system timestamps and generating XML. I'd keep only XML logic here, e.g.:

class RepoXml implements Iterable<Directive> {
  private final Directives xml;

  public RepoXml openSize(long size) {
    return new RepoXml(this.dirs.add("open-size").set(size));
  }

  public RepoXml gzipHash(String hash) {
    return new RepoXml(this.dirs.add("checksum")./*..*/);
  }

  // and other methods to patch XML

  @Override
  public Iterator<Directive> iterator() {
    return this.dirs.iterator();
  }
}

Then you can call it from Repomd like this:

something.map(key -> new RepomXml().key(key))
  .zipWith(Single.fromCallable(() -> Files.size(this.temp)), (xml, size) -> xml.openSize(size))
  .zipWith(Single.fromCallable(() -> Files.size(this.gzip)), (xml, size) -> xml.gzipSize(size))
  .zipWith(new Checksum(this.gzip).sha(), (xml, hash) -> xml.openHash(hash))
  .zipWith(Single.just(System.timestamp()), (xml, time) -> xml.timestamp(time))
  .flatMapCompletable(xml -> new Update(temp).apply(xml))

[Guseyn]

@g4s8 suggestions are applied.

[g4s8]

@Guseyn the name is too vague here, this method loads metadata file by location name in repomd.xml, maybe we can name it metaFile() which will return Single<Path> instead of using Path file parameter?

[Guseyn]

@g4s8 fixed.

[g4s8]

@Guseyn this class can be instantiated internally, since it's just a wrapper for object's state storage field. We can use non-static method and construct it right in the body. Method parameter looks redundant here.

[Guseyn]

@g4s8 fixed.

[Guseyn]

@g4s8 plz see the updates.

[0crat]

This pull request #34 is assigned to @g4s8/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[0crat]

Job #34 is already in scope

[0crat]

Job audit: ARC didn't merge or close PR, performer @g4s8/z/z didn't make CR comments

[0crat]

Job was finished in 2 hours, bonus for fast delivery is possible (see §36)