[WorksForYou] V1 of the view controller

[mennenia]

• Hooked up to network model
• Click on artwork pushes VC
• Loads next works upon scrolling

TODO (on top of what's in #1158)

• Correct spacing
• Show load indicator when scrolling
• Disable horizontal scrolling

Demo:

Scroll and load:

Click:

Will do this later today hopefully, and then separately do new snapshot tests, mark notification as read, etc

[ArtsyOpenSource]

	1 Warning
⚠️	Needs testing on a Phone if change is non-trivial

Generated by 🚫 danger

[orta]

An easy rule to remember is that we never use Avant Garde with lowercase letters, so double check the designs WRT the title

[orta]

does this information need to be public knowledge? e.g. could it of in the .m

[katarinabatina]

@mennenia tiny to do, not sure if you want to add it to this PR or not but the artist names should be all caps. This is looking awesome tho!

[mennenia]

Yup that's been fixed in the label pod :) I know it's not reflected in the gif yet, sorry!

[mennenia]

Okay, @orta I'm ready for this one to be reviewed/closed. I thought I did what I could to disable horizontal scrolling, but that isn't working at the moment. Will revisit.

Upcoming PRs: I will make the artist clickable (which will make the VC a bit nicer, as I'll take out some of the view code and put it in a separate class), sort out iPad (needs some better spacing), then snapshots.

Current looks:

[orta]

It's probably better that you leave this to the view controller - I don't think an user of the model would expect the performance hit that would come with this, ( you can also use ARStandardDateFormatter to use the standard for setting formats )

[mennenia]

Not sure if I follow - the problem is that the type of "publishedAt" is an NSString, even though it's described as an NSDate. Basically, when getting it from the json, the string is put into the property without converting it into a date. If you want I can do this logic in the VC, but then the type should become "NSString *publisedAt" right?

[orta]

Ah, then you need to create a value transformer for it, then it's done on the BG parsing thread, e.g.

+ (NSValueTransformer *)startDateJSONTransformer
{
    return [ARStandardDateFormatter sharedFormatter].stringTransformer;
}

+ (NSValueTransformer *)endDateJSONTransformer
{
    return [ARStandardDateFormatter sharedFormatter].stringTransformer;
}

I think you'd want:

+ (NSValueTransformer *)publishedAtJSONTransformer
{
    return [ARStandardDateFormatter sharedFormatter].stringTransformer;
}

[orta]

Cool beans - this looks solid 10/10